Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for broadcom platform sdk init ready during syncd start. #2931

Merged

Conversation

ramachandrareddygaddam
Copy link
Contributor

- What I did
During boot/reload time, wait in a loop to check for bcm initialization.
Break the loop, once sdk is ready to process the 'bcmcmd' request (or) loop count reached the maximum value.

- How I did it
In the existing implementation during syncd start process will sleep for a fixed time (3 secs)
for sdk initialization to happen. But the time taken for sdk initialization is varying for different platforms.
To fix this issue, the syncd start process wait in a loop and check whether sdk is ready to process 'bcmcmd' command.

- How to verify it
Check for syncd process status and interface status.
Check for syslogs and no failures related to syncd should be present.

Without fix:
This issue is not seen on all platforms.
When this issue is observed, the syncd initialization and ledinit are failed. The system is not in a ready state.
The show commands ('show interface status', 'show arp' etc) will not display any output.

The syslogs contains the below failure information.
2016-12-08 16:22:36,675 INFO success: ledinit entered RUNNING state, process has stayed up for > than 0 seconds (startsecs)
2016-12-08 16:22:36,770 INFO exited: start.sh (exit status 0; expected)
2016-12-08 16:23:36,717 INFO exited: ledinit (exit status 62; not expected)

@lguohan lguohan merged commit 6370d64 into sonic-net:master Jun 19, 2019
mssonicbld added a commit that referenced this pull request Oct 26, 2023
…lly (#17017)

#### Why I did it
src/sonic-swss
```
* 5bee57a4 - (HEAD -> 202305, origin/202305) Fix data race in on_switch_shutdown_request() (#2931) (16 hours ago) [Yakiv Huryk]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants